class Ameba::Rule::Style::IsAFilter
- Ameba::Rule::Style::IsAFilter
- Ameba::Rule::Base
- Reference
- Object
Overview
This rule is used to identify usage of is_a?/nil?
calls within filters.
For example, this is considered invalid:
matches = %w[Alice Bob].map(&.match(/^A./))
matches.any?(&.is_a?(Regex::MatchData)) # => true
matches.one?(&.nil?) # => true
typeof(matches.reject(&.nil?)) # => Array(Regex::MatchData | Nil)
typeof(matches.select(&.is_a?(Regex::MatchData))) # => Array(Regex::MatchData | Nil)
And it should be written as this:
matches = %w[Alice Bob].map(&.match(/^A./))
matches.any?(Regex::MatchData) # => true
matches.one?(Nil) # => true
typeof(matches.reject(Nil)) # => Array(Regex::MatchData)
typeof(matches.select(Regex::MatchData)) # => Array(Regex::MatchData)
YAML configuration example:
Style/IsAFilter:
Enabled: true
FilterNames:
- select
- reject
- any?
- all?
- none?
- one?
Included Modules
- YAML::Serializable
- YAML::Serializable::Strict
Defined in:
ameba/rule/style/is_a_filter.crConstant Summary
-
MSG =
"Use `%s` instead of `%s`"
-
NEW =
"%s(%s)"
-
OLD =
"%s {...}"
Constructors
- .new(ctx : YAML::ParseContext, node : YAML::Nodes::Node)
-
.new(config = nil)
This rule is used to identify usage of
is_a?/nil?
calls within filters.
Instance Method Summary
- #description : String
- #description=(description : String)
- #enabled : Bool
- #enabled=(enabled : Bool)
- #excluded : Array(String) | Nil
- #excluded=(excluded : Array(String) | Nil)
- #filter_names : Array(String)
- #filter_names=(filter_names : Array(String))
- #severity : Ameba::Severity
- #severity=(severity : Ameba::Severity)
- #test(source, node : Crystal::Call)
- #test(source)
Instance methods inherited from class Ameba::Rule::Base
==(other)
==,
catch(source : Source)
catch,
excluded?(source)
excluded?,
group
group,
hash
hash,
name
name,
special?
special?,
test(source : Source, node : Crystal::ASTNode, *opts)test(source : Source) test
Class methods inherited from class Ameba::Rule::Base
parsed_doc
parsed_doc
Constructor Detail
def self.new(config = nil)
#
This rule is used to identify usage of is_a?/nil?
calls within filters.
For example, this is considered invalid:
matches = %w[Alice Bob].map(&.match(/^A./))
matches.any?(&.is_a?(Regex::MatchData)) # => true
matches.one?(&.nil?) # => true
typeof(matches.reject(&.nil?)) # => Array(Regex::MatchData | Nil)
typeof(matches.select(&.is_a?(Regex::MatchData))) # => Array(Regex::MatchData | Nil)
And it should be written as this:
matches = %w[Alice Bob].map(&.match(/^A./))
matches.any?(Regex::MatchData) # => true
matches.one?(Nil) # => true
typeof(matches.reject(Nil)) # => Array(Regex::MatchData)
typeof(matches.select(Regex::MatchData)) # => Array(Regex::MatchData)
YAML configuration example:
Style/IsAFilter:
Enabled: true
FilterNames:
- select
- reject
- any?
- all?
- none?
- one?